Skip to content

Launchpad Search: Searches only when nothing is found #3770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Launchpad Search: Searches only when nothing is found #3770

wants to merge 1 commit into from

Conversation

sergeibbb
Copy link
Member

@sergeibbb sergeibbb commented Nov 18, 2024 •
edited
Loading

(#3763)

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

sergeibbb pushed a commit that referenced this pull request Nov 18, 2024
@chivorotkiv
Searches only when nothing is found
ba24f42 
(#3763, #3770)
@sergeibbb sergeibbb force-pushed the 3763-launchpad-search-search-only-when-nothing-is-found branch from d30067e to ba24f42 Compare November 18, 2024 13:02
@sergeibbb sergeibbb self-assigned this Nov 18, 2024
@sergeibbb sergeibbb linked an issue Nov 18, 2024 that may be closed by this pull request
Launchpad Search: search only when nothing is found #3763
Closed
@sergeibbb sergeibbb changed the title Searches only when nothing is found Launchpad Search: Searches only when nothing is found Nov 18, 2024
sergiolms
sergiolms reviewed Nov 18, 2024
View reviewed changes
sergeibbb pushed a commit that referenced this pull request Nov 19, 2024
@chivorotkiv @sergeibbb
Searches only when nothing is found
bc466d0 
(#3763, #3770)
@sergeibbb sergeibbb force-pushed the 3763-launchpad-search-search-only-when-nothing-is-found branch from ba24f42 to bc466d0 Compare November 19, 2024 11:58
@sergiolms
Copy link
Contributor

Hey @sergeibbb, while reviewing your PR, I'd suggest the following code changes:

👉 Code Suggestion for #3770

#3770

You can also review and apply these suggestions locally on your machine.

Learn more about GitKraken Code Suggest

Code Suggest liberates your code reviews from GitHub's restrictive, comment-only feedback style. As simple as suggesting changes in a Google-doc, provide real code suggestions from where you code, e.g. your IDE, and on anything in your project — not just on the lines of code changed in the PR.

Join your team on GitKraken to speed up PR review.

@sergeibbb sergeibbb removed the request for review from axosoft-ramint November 19, 2024 14:48
sergeibbb pushed a commit that referenced this pull request Nov 25, 2024
@chivorotkiv @sergeibbb
Searches only when nothing is found
529e536 
(#3763, #3770)
@sergeibbb sergeibbb force-pushed the 3763-launchpad-search-search-only-when-nothing-is-found branch from bc466d0 to 529e536 Compare November 25, 2024 04:42
sergeibbb pushed a commit that referenced this pull request Nov 25, 2024
@chivorotkiv @sergeibbb
Searches only when nothing is found
162f26a 
(#3763, #3770)
sergeibbb added a commit that referenced this pull request Nov 25, 2024
@sergeibbb
Improves delayed detection of active items: uses onDidChangeActive
9b17351 
instead of a timout delay
(#3763, #3770)
@sergeibbb sergeibbb force-pushed the 3763-launchpad-search-search-only-when-nothing-is-found branch from 529e536 to 9b17351 Compare November 25, 2024 05:15
@sergeibbb
Copy link
Member Author

@sergiolms
I've accepted your solution with onDidChangeActive. Thank you.

sergiolms
sergiolms approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@sergiolms sergiolms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working for me, I couldn't reproduce the reported issue anymore

@chivorotkiv @sergeibbb
Searches only when nothing is found,
e8fb0f3 
and improves delayed detection of active items: uses `onDidChangeActive` instead of a timout delay
(#3763, #3770)
@sergeibbb sergeibbb force-pushed the 3763-launchpad-search-search-only-when-nothing-is-found branch from 9b17351 to e8fb0f3 Compare December 17, 2024 14:31
@sergeibbb sergeibbb closed this Dec 17, 2024
@sergeibbb sergeibbb deleted the 3763-launchpad-search-search-only-when-nothing-is-found branch December 17, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@axosoft-ramint axosoft-ramint Awaiting requested review from axosoft-ramint

1 more reviewer

@sergiolms sergiolms sergiolms approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sergeibbb sergeibbb

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Launchpad Search: search only when nothing is found

3 participants

@sergeibbb @sergiolms @chivorotkiv